Add MIT license #37
Merged
Add MIT license #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately, I can't do this without the consent of the original maintainers, I'll give it a look tomorrow. I'd like to license it as well, avoids a lot of trouble |
|
I am the original maintainer, this is fine with me I usually go with MIT guess I just forgot to add it |
|
Great, thanks guys. I updated this to use your full name @briankircho, so it should be good to go. |
|
Ok, merged, thanks :) |
|
Thanks @sieira! Would it be possible to get a new version released to include the license too? |
|
It's done, I hope there are no regressions (proxies may be a problem for now) |
|
@sieira Thanks! Can you please elaborate on the potential proxies problem? I'm not quite sure what that refers to. |
|
See my last comment here #39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd be more comfortable using this if it had a license. Are there any objections to MIT, chosen from http://choosealicense.com/?
Thanks for maintaining this lib!